[
https://issues.apache.org/jira/browse/SOLR-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649044#comment-13649044
]
Ryan Ernst commented on SOLR-4448:
----------------------------------
This looks like it at least makes the load balancer pluggable if you are
already plugging in your own shard handler factory. I think making it
pluggable outside of that context is better for the future, but should be a
separate jira.
One thing I don't currently like (even before your patch) is the fact that the
load balancer lives in solrj. It is just an odd place, since this is a core
part of how distributed search works.
I think a better design, even if the existing default implementation stays in
solrj, is to have an abstract class in solr core, which is all shard handler
factory should know about. This should be really simple (one or two methods
for configuration and sending requests). Then the LB in solrj can extend from
it, and other load balancer implementations don't need to extend from a class
in solrj.
Regardless of those comments:
+1 to the patch as is.
> Allow the solr internal load balancer to be more easily pluggable.
> ------------------------------------------------------------------
>
> Key: SOLR-4448
> URL: https://issues.apache.org/jira/browse/SOLR-4448
> Project: Solr
> Issue Type: New Feature
> Components: SolrCloud
> Reporter: philip hoy
> Priority: Minor
> Attachments: SOLR-4448.patch, SOLR-4448.patch
>
>
> Widen some access level modifiers to allow the load balancer to be extended
> and plugged into an HttpShardHandler instance using an extended
> HttpShardHandlerFactory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
