[ 
https://issues.apache.org/jira/browse/SOLR-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649265#comment-13649265
 ] 

Ryan Ernst commented on SOLR-4448:
----------------------------------

{quote}
The load balancing capability is inherently a client feature.
{quote}

Load balancing is used by distributed search.  It happens to also be used for 
uploading documents, which is a client feature.  Clients shouldn't be using 
this for sending distributed search requests.  Solr does that.

{quote}
There's no reason for SolrJ and the Solr core to have different 
implementations, and there is strong precedence for putting common Solr/SolrJ 
features into SolrJ.
{quote}

I don't know much about SolrJ.  What I really care about is not having to 
inherit from the default implementation, but instead having an abstraction.

That said, I still think this patch is fine as is.


                
> Allow the solr internal load balancer to be more easily pluggable.
> ------------------------------------------------------------------
>
>                 Key: SOLR-4448
>                 URL: https://issues.apache.org/jira/browse/SOLR-4448
>             Project: Solr
>          Issue Type: New Feature
>          Components: SolrCloud
>            Reporter: philip hoy
>            Priority: Minor
>         Attachments: SOLR-4448.patch, SOLR-4448.patch
>
>
> Widen some access level modifiers to allow the load balancer to be extended 
> and plugged into an HttpShardHandler instance using an extended 
> HttpShardHandlerFactory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to