[ 
https://issues.apache.org/jira/browse/LUCENE-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shai Erera updated LUCENE-4982:
-------------------------------

    Attachment: LUCENE-4982.patch

Patch adds a test to TestMockDirWrapper and factors out checkDiskFull method in 
MockIOWrapper. The signature is a bit ugly, but that's needed because 
checkDiskFull copies the remaining bytes, and writeBytes copies from an array 
while copyBytes from DataInput. I don't think it's the end of the world, but if 
anyone has an idea how to do it better...

I ran core tests and they passed (actually only 3 tests under core set 
dir.maxSize).
                
> Make MockIndexOutputWrapper check disk full on copyBytes
> --------------------------------------------------------
>
>                 Key: LUCENE-4982
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4982
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/test-framework
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>         Attachments: LUCENE-4982.patch
>
>
> While working on the consistency test for Replicator (LUCENE-4975), I noticed 
> that I don't trip disk-full exceptions and tracked it down to 
> MockIndexOutputWrapper.copyBytes not doing these checks like writeBytes. I'd 
> like to add this check.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to