[ https://issues.apache.org/jira/browse/LUCENE-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shai Erera updated LUCENE-4982: ------------------------------- Attachment: LUCENE-4982.patch I modified the test to set maxSize=2 and then write 2 bytes in two calls. The first should succeed, the second fail. However, even the first fails and now I don't know if it's a bug in the test or MockIO.checkDiskFull(). The latter (copy of the original code) does {{freeSpace <= len}} -- is this ok? I mean, if I have room for 2 bytes and the caller asks to write 2 bytes, should we really fail on diskFull? > Make MockIndexOutputWrapper check disk full on copyBytes > -------------------------------------------------------- > > Key: LUCENE-4982 > URL: https://issues.apache.org/jira/browse/LUCENE-4982 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/test-framework > Reporter: Shai Erera > Assignee: Shai Erera > Attachments: LUCENE-4982.patch, LUCENE-4982.patch > > > While working on the consistency test for Replicator (LUCENE-4975), I noticed > that I don't trip disk-full exceptions and tracked it down to > MockIndexOutputWrapper.copyBytes not doing these checks like writeBytes. I'd > like to add this check. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org