[
https://issues.apache.org/jira/browse/SOLR-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13658772#comment-13658772
]
Stephen Riesenberg edited comment on SOLR-4816 at 5/15/13 8:57 PM:
-------------------------------------------------------------------
{quote}It's collection specific.
See DocCollection.getRouter(){quote}
No javadoc on that method. In my environment, collections were set up for
implicit routing because numShards was not specified at create time. Joel
straightened us out. Only thing I found was at
http://wiki.apache.org/solr/SolrCloud#Creating_cores_via_CoreAdmin which
doesn't talk about document routing.
The NPEs I mentioned before have been fixed, one other fix was made to set the
commitWithinMS and pass params to the sub-requests *and* document router. Now I
am running a load test against this to see how it performs. I'll post an
updated patch with my changes a bit later.
{quote}We should make sure we have tests that would have caught these as
well!{quote}
I didn't run the test suite. Seems like a good idea! I'll get caught up
eventually. Having run it now with the earlier patches, seeing the NPEs. Good
stuff. Thanks.
was (Author: sriesenberg):
{quote}It's collection specific.
See DocCollection.getRouter(){quote}
No javadoc on that method. In my environment, collections were set up for
implicit routing because numShards was not specified at create time. Joel
straightened us out. Only thing I found was at
http://wiki.apache.org/solr/SolrCloud#Creating_cores_via_CoreAdmin which
doesn't talk about document routing.
The NPEs I mentioned before have been fixed, one other fix was made to set the
commitWithinMS and pass params to the sub-requests. Now I am running a load
test against this to see how it performs. I'll post an updated patch with my
changes a bit later.
{quote}We should make sure we have tests that would have caught these as
well!{quote}
I didn't run the test suite. Seems like a good idea! I'll get caught up
eventually. Having run it now with the earlier patches, seeing the NPEs. Good
stuff. Thanks.
> Change CloudSolrServer to send updates to the correct shard
> -----------------------------------------------------------
>
> Key: SOLR-4816
> URL: https://issues.apache.org/jira/browse/SOLR-4816
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Affects Versions: 4.3
> Reporter: Joel Bernstein
> Priority: Minor
> Attachments: SOLR-4816.patch, SOLR-4816.patch, SOLR-4816.patch,
> SOLR-4816.patch, SOLR-4816-sriesenberg.patch
>
>
> This issue changes CloudSolrServer so it routes update requests to the
> correct shard. This would be a nice feature to have to eliminate the document
> routing overhead on the Solr servers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
