[ 
https://issues.apache.org/jira/browse/SOLR-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661369#comment-13661369
 ] 

Stephen Riesenberg edited comment on SOLR-4816 at 5/18/13 2:59 PM:
-------------------------------------------------------------------

Sorry, was away yesterday. Your patch is getting beyond my original changes, so 
I won't post it again. In regards to commitWithin, you need the original 
request when you create a new sub-request. Then basically 
{{newRequest.setCommitWithin(originalRequest.getCommitWithin());}}

You could only do this in the new getRoutes() method if you have the original 
request available. Hope that helps!

*Edit:* Also, this line:

{code:java}Slice slice = 
router.getTargetSlice(doc.getFieldValue(id).toString(),doc,null,col);{code}

Would be:

{code:java}Slice slice = 
router.getTargetSlice(doc.getFieldValue(id).toString(),doc,params,col);{code}

I got an NPE when passing null to the DocRouter.
                
      was (Author: sriesenberg):
    Sorry, was away yesterday. Your patch is getting beyond my original 
changes, so I won't post it again. In regards to commitWithin, you need the 
original request when you create a new sub-request. Then basically 
{{newRequest.setCommitWithin(originalRequest.getCommitWithin());}}

You could only do this in the new getRoutes() method if you have the original 
request available. Hope that helps!
                  
> Change CloudSolrServer to send updates to the correct shard
> -----------------------------------------------------------
>
>                 Key: SOLR-4816
>                 URL: https://issues.apache.org/jira/browse/SOLR-4816
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>    Affects Versions: 4.3
>            Reporter: Joel Bernstein
>            Priority: Minor
>         Attachments: SOLR-4816.patch, SOLR-4816.patch, SOLR-4816.patch, 
> SOLR-4816.patch, SOLR-4816.patch, SOLR-4816.patch, SOLR-4816.patch, 
> SOLR-4816.patch, SOLR-4816-sriesenberg.patch
>
>
> This issue changes CloudSolrServer so it routes update requests to the 
> correct shard. This would be a nice feature to have to eliminate the document 
> routing overhead on the Solr servers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to