[
https://issues.apache.org/jira/browse/SOLR-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681446#comment-13681446
]
Robert Muir commented on SOLR-4872:
-----------------------------------
{quote}
However, if he's right, and Tokenizer.close() amounts to
Tokenizer.cleanUpReader(), I am left wishing over there that there was, a
Tokenizer.reallyClose().
{quote}
The close method is on TokenStream. Maybe it would be better if
TokenStream.close() meant reallyClose :)
I dont understand why Tokenizer.close() needs to do anything with a Reader.
Really since the reader is passed in from the consumer, consumer should be
responsible for closing it. At least this is my opinion.
The only downside to changing all this, is it would impact all lucene
installations in a sneaky way, as now the users are responsible for closing
their Readers, whereas they weren't before.
> Allow analyzers to be SolrCoreAware
> -----------------------------------
>
> Key: SOLR-4872
> URL: https://issues.apache.org/jira/browse/SOLR-4872
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.3
> Reporter: Benson Margulies
>
> I have a need, in an analyzer, to have a shared cache that is cleaned up when
> the core is torn down. Solr rejects analyzer components that are
> SolrCoreAware. Is there some really good reason for this? What harm would
> come from allowing one to register a CloseHook?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
