[
https://issues.apache.org/jira/browse/LUCENE-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681988#comment-13681988
]
Uwe Schindler edited comment on LUCENE-5055 at 6/13/13 7:24 AM:
----------------------------------------------------------------
I improved the patch a littel bit to catch further thins (optionally for some
modules):
- tools/forbiddenApis/**
This is done by an generally empty property $\{rat.additional-includes\}, which
is defined by those modules. Evereything in this property is a pattern applied
to the module's home dir
I found one license problem:
- If I add "tools/prettify/**" it complains, because all those Javascript files
contain no license header! We should fix this (although they are
compressed&unreadable Javascript), but generally Javascript compressors keep
license headers!
was (Author: thetaphi):
I improved the patch a littel bit to catch further thins (optionally for
some modules):
- tools/forbiddenApis/**
This is done by an generally empty property ${rat.additional-includes}, which
is defined by those modules. Evereything in this property is a pattern applied
to the module's home dir
I found one license problem:
- If I add {tools/prettify/**} it complain, because all those Javascript files
contain no license header! We should fix this (although they are
compressed&unreadable Javascript), but generally Javascript compressors keep
license headers!
> rat-sources target is missing build and ivy xml files
> -----------------------------------------------------
>
> Key: LUCENE-5055
> URL: https://issues.apache.org/jira/browse/LUCENE-5055
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
> Reporter: Ryan Ernst
> Assignee: Uwe Schindler
> Fix For: 5.0, 4.4
>
> Attachments: LUCENE-5055.patch, LUCENE-5055.patch
>
>
> The check for copyright notices in files isn't checking all files, only
> source/test files. A couple modules xml files are missing this (join,
> spatial, and custom-tasks.xml).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
