[ 
https://issues.apache.org/jira/browse/LUCENE-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682012#comment-13682012
 ] 

Ryan Ernst edited comment on LUCENE-5055 at 6/13/13 8:27 AM:
-------------------------------------------------------------

Thanks Uwe!

With your additional-includes property, can these checks be moved to the 
modules which need it?
{code:xml}
<!-- some modules have a src/tools/[java,test] -->
<fileset dir="src/tools/java" excludes="${rat.excludes}" 
erroronmissingdir="false"/>
<fileset dir="src/tools/test" excludes="${rat.excludes}" 
erroronmissingdir="false"/>
{code}
                
      was (Author: rjernst):
    Thanks Uwe!

With your additional-includes property, can check be moved to the modules which 
need it?
bq. {{<fileset dir="src/tools/java" excludes="${rat.excludes}" 
erroronmissingdir="false"/>}}
                  
> rat-sources target is missing build and ivy xml files
> -----------------------------------------------------
>
>                 Key: LUCENE-5055
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5055
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: general/build
>            Reporter: Ryan Ernst
>            Assignee: Uwe Schindler
>             Fix For: 5.0, 4.4
>
>         Attachments: LUCENE-5055.patch, LUCENE-5055.patch, LUCENE-5055.patch
>
>
> The check for copyright notices in files isn't checking all files, only 
> source/test files.  A couple modules xml files are missing this (join, 
> spatial, and custom-tasks.xml).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to