[
https://issues.apache.org/jira/browse/SOLR-4998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702501#comment-13702501
]
Jack Krupansky commented on SOLR-4998:
--------------------------------------
I was going to propose that we discourage the use of the term "slice" outside
of the core Solr code, but... that's where we run into ClusterState being
exposed to the whole world in SolrJ, with "slice" being the preferred term
there instead of "shard".
It is interesting that the clusterstate.json JSON itself doesn't have the
terminology problem since it consists primarily of values, like shard IDs, and
does in fact use "shards" as the map name for... slices. So, clusterstate.json
and the Zookeeper browser in the Solr Admin UI seem fine, as is.
Back to the ClusterState class exposed in SolrJ... it really is heavily "slice"
oriented, but... the good news is that it's only references to "shard" are for
"shardId", with an explicit equivalence of slice and shard as in "getShardId...
Get the slice/shardId for a core." Replica is the main object below slice, so
we don't see the logical/physical "shard" distinction here in ClusterState.
So, I think we can finesse the problem by adding a ClusterState Javadoc caveat
of "Slice and shard are the same in ClusterState; slice name is the same as
shard ID."
Do we have any explicit doc for clusterstate.json? Not that I know of (my book
will have it though in a few weeks!). The point is that the map keys below the
"shards" map key are "shard IDs". And we can note that shard ID is sometimes
referred to as a slice name.
> Make the use of Slice and Shard consistent across the code and document base
> ----------------------------------------------------------------------------
>
> Key: SOLR-4998
> URL: https://issues.apache.org/jira/browse/SOLR-4998
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Affects Versions: 4.3, 4.3.1
> Reporter: Anshum Gupta
>
> The interchangeable use of Slice and Shard is pretty confusing at times. We
> should define each separately and use the apt term whenever we do so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
