[
https://issues.apache.org/jira/browse/SOLR-4998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702923#comment-13702923
]
Jack Krupansky commented on SOLR-4998:
--------------------------------------
I stumbled across this logging message as well, in
OverseerCollectionProcessor.createCollection:
{code}
for (int i = 1; i <= numSlices; i++) {
for (int j = 1; j <= repFactor; j++) {
String nodeName = nodeList.get((repFactor * (i - 1) + (j - 1)) %
nodeList.size());
String sliceName = "shard" + i;
String shardName = collectionName + "_" + sliceName + "_replica" + j;
log.info("Creating shard " + shardName + " as part of slice "
+ sliceName + " of collection " + collectionName + " on "
+ nodeName);
{code}
I think that could just become:
{code}
log.info("Creating replica " + shardName + " as part of shard "
+ sliceName + " of collection " + collectionName + " on "
+ nodeName);
{code}
And in OverseerCollectionProcessor.splitShard:
{code}
log.info("Creating shard " + subShardName + " as part of slice "
+ subSlice + " of collection " + collectionName + " on "
+ nodeName);
{code}
Could become:
{code}
log.info("Creating replica " + subShardName + " as part of shard "
+ subSlice + " of collection " + collectionName + " on "
+ nodeName);
{code}
> Make the use of Slice and Shard consistent across the code and document base
> ----------------------------------------------------------------------------
>
> Key: SOLR-4998
> URL: https://issues.apache.org/jira/browse/SOLR-4998
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Affects Versions: 4.3, 4.3.1
> Reporter: Anshum Gupta
>
> The interchangeable use of Slice and Shard is pretty confusing at times. We
> should define each separately and use the apt term whenever we do so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
