[ 
https://issues.apache.org/jira/browse/SOLR-5022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704656#comment-13704656
 ] 

Mark Miller commented on SOLR-5022:
-----------------------------------

bq. Can we put the client classes into a smaller JAR?

Simple in theory, hard in practice I think - especially on an ongoing basis.

bq. Then we would add the student-first-year MiniDFSCluster into a separate JAR 
and run it only with tests. 

It already is in a separate jar - a test jar that is not part of Solr.

bq. but would make the Solr WAR smaller. 

Not that noticeably - these jars are already pretty small from a size 
perspective.

bq. It would also ensure, that no core class accidently starts hadoop

I don't think that's a valid concern - you *cannot* do this easily at all - 
first, without the dfsminitcluster code from the test jars, good luck to you. 
Second, without the other test dependencies, hdfs won't start. So this is like 
saying, someone in the future could write a virus into Solr - we better not run 
code. The only way you could load all those classes is if you were hell bent on 
doing it, and even then it would not be easy.
                
> PermGen exhausted test failures on Jenkins.
> -------------------------------------------
>
>                 Key: SOLR-5022
>                 URL: https://issues.apache.org/jira/browse/SOLR-5022
>             Project: Solr
>          Issue Type: Test
>          Components: Tests
>            Reporter: Mark Miller
>            Assignee: Uwe Schindler
>            Priority: Blocker
>             Fix For: 5.0, 4.4
>
>         Attachments: intern-count-win.txt, SOLR-5022.patch, 
> SOLR-5022-permgen.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to