[
https://issues.apache.org/jira/browse/SOLR-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704706#comment-13704706
]
Erick Erickson commented on SOLR-4914:
--------------------------------------
A massive patch, so I haven't looked in great detail, but few comments:
1> CoreAdminCreateDiscoverTest, there has been a change from testing that
specific properties are preserved to just checking the number of properties.
That test was written that way specifically because instanceDir was being
preserved in the core.properties file. The way it is if we inadvertently
preserved instanceDir but left out, say dataDir the test would pass. Can you
put that back?
2> TestCoreContainer.testPersist is removed, what replaces it?
Next step: Removing persistence in 5.x!
About your point 2, creating two cores with same instance dir. Last I knew
there was a check at startup time to report this, but I agree it's a bit of a
trap.
> Factor out core discovery and persistence logic
> -----------------------------------------------
>
> Key: SOLR-4914
> URL: https://issues.apache.org/jira/browse/SOLR-4914
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 5.0
> Reporter: Erick Erickson
> Assignee: Alan Woodward
> Attachments: SOLR-4914.patch, SOLR-4914.patch, SOLR-4914.patch,
> SOLR-4914.patch, SOLR-4914.patch, SOLR-4914.patch
>
>
> Alan Woodward has done some work to refactor how core persistence works that
> we should work on going forward that I want to separate from a shorter-term
> tactical problem (See SOLR-4910).
> I'm attaching Alan's patch to this JIRA and we'll carry it forward separately
> from 4910.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
