[
https://issues.apache.org/jira/browse/SOLR-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704739#comment-13704739
]
Alan Woodward commented on SOLR-4914:
-------------------------------------
re CoreAdminCreateDiscoverTest, the lines immediately prior to the size check
are checks for the four properties in question, so that's covered.
re testPersist, that's covered by TestSolrXMLPersistence and TestCoreDiscovery.
But some more tests here would be good, I agree...
re cores sharing instance dir, startup time will be too late to detect the
problem here. Creating a new core via the CoreAdminHandler will overwrite any
existing core.properties file. Maybe the way to deal with this is to call
locator.persist() before we call create(), and throw an exception from
CorePropertiesLocator. Will try and work something up.
I also think that this may remove the need to deprecate persistence - it's a
lot more maintainable now.
> Factor out core discovery and persistence logic
> -----------------------------------------------
>
> Key: SOLR-4914
> URL: https://issues.apache.org/jira/browse/SOLR-4914
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 5.0
> Reporter: Erick Erickson
> Assignee: Alan Woodward
> Attachments: SOLR-4914.patch, SOLR-4914.patch, SOLR-4914.patch,
> SOLR-4914.patch, SOLR-4914.patch, SOLR-4914.patch
>
>
> Alan Woodward has done some work to refactor how core persistence works that
> we should work on going forward that I want to separate from a shorter-term
> tactical problem (See SOLR-4910).
> I'm attaching Alan's patch to this JIRA and we'll carry it forward separately
> from 4910.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
