[ https://issues.apache.org/jira/browse/SOLR-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13716459#comment-13716459 ]
Erick Erickson commented on SOLR-5057: -------------------------------------- Didn't mean to sound like it wouldn't be done, just making you aware that you only have read-only access to the repository and one of the committers has to pick it up and commit it. That said, I took a quick look at it and it looks reasonable, I've assigned it to myself. I rearranged things a bit (I think the test you wrote fits better in a pre-existing file), I'll attach the change momentarily. Do you think you could extend this for the filterCache to? That way we'd be able to re-use the filterCache when the fq clauses were ordered differently. [~yo...@apache.org] [~hossman_luc...@fucit.org] I've gotten myself in trouble by not understanding the nuances of query semantics, do you see a problem with this approach? Seems like an easy win, which makes me nervous that it hasn't been done before <G>... Erick > queryResultCache should not related with the order of fq's list > --------------------------------------------------------------- > > Key: SOLR-5057 > URL: https://issues.apache.org/jira/browse/SOLR-5057 > Project: Solr > Issue Type: Improvement > Components: search > Affects Versions: 4.0, 4.1, 4.2, 4.3 > Reporter: Feihong Huang > Priority: Minor > Attachments: SOLR-5057.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > There are two case query with the same meaning below. But the case2 can't use > the queryResultCache when case1 is executed. > case1: q=*:*&fq=field1:value1&fq=field2:value2 > case2: q=*:*&fq=field2:value2&fq=field1:value1 > I think queryResultCache should not be related with the order of fq's list. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org