[
https://issues.apache.org/jira/browse/LUCENE-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719263#comment-13719263
]
Shai Erera commented on LUCENE-5133:
------------------------------------
Patch looks good. A couple of comments on addWholeMatch:
* The javadocs seem wrong - say that the match is appended to a StringBuilder.
* The parameter analyzed is not used by the method. If it should be there (for
extending classes?), perhaps document what it means?
> AnalyzingInfixSuggester should return structured highlighted results instead
> of single String per result
> --------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-5133
> URL: https://issues.apache.org/jira/browse/LUCENE-5133
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Fix For: 5.0, 4.5
>
> Attachments: LUCENE-5133.patch
>
>
> Today it renders to an HTML string (<b>..</b> for hits) in protected
> methods that one can override to change the highlighting, but this is
> hard/inefficient to use for search servers that want to e.g. return
> JSON representation of the highlighted result.
> This is the same issue as LUCENE-4906 (PostingsHighlighter) but for
> AnalyzingInfixSuggester's highlights instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
