[ 
https://issues.apache.org/jira/browse/LUCENE-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719749#comment-13719749
 ] 

Robert Muir commented on LUCENE-5133:
-------------------------------------

Why not use Object like the patch on LUCENE-4906 and try to get some 
consistency:
I can easily see this becoming hell because different expert users want 
different things.

It might work for your particular case to have String text + boolean, but other 
people might want to know crazy things like:
* score for the passage
* which multi-valued field instance they hit
* position or something of the passage within the doc

In general I also think its really bad to add additional classes that users 
must learn (the previous api here is "string", which everyone already knows). 

anyway i dont care too much for this class, but I'd hate for us to make this 
mistake over on LUCENE-4906. I feel like the other highlighters already 
introduce way too many new classes (besides already known simple ones like 
IndexSearcher,TopDocs,String, etc) and it makes them difficult to use.
                
> AnalyzingInfixSuggester should return structured highlighted results instead 
> of single String per result
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-5133
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5133
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>             Fix For: 5.0, 4.5
>
>         Attachments: LUCENE-5133.patch, LUCENE-5133.patch
>
>
> Today it renders to an HTML string (<b>..</b> for hits) in protected
> methods that one can override to change the highlighting, but this is
> hard/inefficient to use for search servers that want to e.g. return
> JSON representation of the highlighted result.
> This is the same issue as LUCENE-4906 (PostingsHighlighter) but for
> AnalyzingInfixSuggester's highlights instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to