[
https://issues.apache.org/jira/browse/SOLR-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736744#comment-13736744
]
Robert Muir commented on SOLR-3076:
-----------------------------------
{quote}
Since no one seems to have issues with any of the important parts like
the public APIs, I plan on committing this shortly.
{quote}
Uhhh, the code is important to some of us too. There are several objections
listed on this issue.
The patches contributed here took lucene's join module and integrated it into
solr, actually thats the description of the issue "Lucene has the ability to do
block joins, we should add it to Solr.".
But then suddenly the code becomes garbage: your patch *FORKS CODE OF ENTIRE
LUCENE JOIN MODULE* to make it slow and top-level. Why even bring in
lucene-join.jar here?
So yeah, i dont care if you think code is important or not, -1 to this.
> Solr(Cloud) should support block joins
> --------------------------------------
>
> Key: SOLR-3076
> URL: https://issues.apache.org/jira/browse/SOLR-3076
> Project: Solr
> Issue Type: New Feature
> Reporter: Grant Ingersoll
> Assignee: Yonik Seeley
> Fix For: 4.5, 5.0
>
> Attachments: 27M-singlesegment-histogram.png, 27M-singlesegment.png,
> bjq-vs-filters-backward-disi.patch, bjq-vs-filters-illegal-state.patch,
> child-bjqparser.patch, dih-3076.patch, dih-config.xml,
> parent-bjq-qparser.patch, parent-bjq-qparser.patch, Screen Shot 2012-07-17 at
> 1.12.11 AM.png, SOLR-3076-childDocs.patch, SOLR-3076.patch, SOLR-3076.patch,
> SOLR-3076.patch, SOLR-3076.patch, SOLR-3076.patch, SOLR-3076.patch,
> SOLR-3076.patch, SOLR-3076.patch, SOLR-3076.patch, SOLR-3076.patch,
> SOLR-3076.patch, SOLR-3076.patch, SOLR-3076.patch,
> SOLR-7036-childDocs-solr-fork-trunk-patched,
> solrconf-bjq-erschema-snippet.xml, solrconfig.xml.patch,
> tochild-bjq-filtered-search-fix.patch
>
>
> Lucene has the ability to do block joins, we should add it to Solr.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
