[
https://issues.apache.org/jira/browse/SOLR-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736830#comment-13736830
]
Uwe Schindler commented on SOLR-3076:
-------------------------------------
Hi,
I don't think we should again start with
bq. Ah, the joy of lucene vs solr politics
again! As far as I understand, the current issue is: Solr has no way to cache
filters per segment, so Yonik forked the whole (or major parts) of the Lucene
join module into the source code of Solr. This also includes using OpenBitSet
instead of FixedBitSet (why?).
I would suggest to proceed like this:
- Delay committing for now
- Open new issue to allow per-segment caches in Solr
- Open new issue to move away from OpenBitSet as a requirement for caching
filters in Solr. For filter caching, FixedBitSet is the better alternative, as
filters always have a fixed number of documents. Also reuse
CachingWrapperFilter in Solr and don't have a separate filter caching. This
would also allow to use the new Bitset implementations in Solr that were
recently added to Lucene. Solr should simply have a non-implementation-agnostic
caching for DocIdSets.
- Once this is committed, adapt the current patch to use the new filter caching.
>From what I have learned in the past: Once we have the forked code in Solr
>there is no way to move away from it, mainly because:
- Backwards compatibility complaints of plugin authors
- "It's already implemented and working - why change?"
- Some people claim that "Top-level caches are not slow".
So my clear -1 from committing the forked code and delay it a few more weeks
and instead fix the dependent issues as noted above before this one.
> Solr(Cloud) should support block joins
> --------------------------------------
>
> Key: SOLR-3076
> URL: https://issues.apache.org/jira/browse/SOLR-3076
> Project: Solr
> Issue Type: New Feature
> Reporter: Grant Ingersoll
> Fix For: 4.5, 5.0
>
> Attachments: 27M-singlesegment-histogram.png, 27M-singlesegment.png,
> bjq-vs-filters-backward-disi.patch, bjq-vs-filters-illegal-state.patch,
> child-bjqparser.patch, dih-3076.patch, dih-config.xml,
> parent-bjq-qparser.patch, parent-bjq-qparser.patch, Screen Shot 2012-07-17 at
> 1.12.11 AM.png, SOLR-3076-childDocs.patch, SOLR-3076.patch, SOLR-3076.patch,
> SOLR-3076.patch, SOLR-3076.patch, SOLR-3076.patch, SOLR-3076.patch,
> SOLR-3076.patch, SOLR-3076.patch, SOLR-3076.patch, SOLR-3076.patch,
> SOLR-3076.patch, SOLR-3076.patch, SOLR-3076.patch,
> SOLR-7036-childDocs-solr-fork-trunk-patched,
> solrconf-bjq-erschema-snippet.xml, solrconfig.xml.patch,
> tochild-bjq-filtered-search-fix.patch
>
>
> Lucene has the ability to do block joins, we should add it to Solr.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
