[
https://issues.apache.org/jira/browse/SOLR-5168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13742907#comment-13742907
]
Mikhail Khludnev commented on SOLR-5168:
----------------------------------------
ok. checked it again. I propose either apply that one-liner patch or trigger
forceMerge() in test. After that testGrandChildren() still fails and it's
fairly reasonable, though gives a subject for considerations:
right now BJQParserTest.addGrandChildren() places _grand children_ before
_their parents_ (i.e children). It sounds like user is aware of physical layout
which is necessary for bjq and enforces it. Unfortunately,
AddUpdateCommand.flatten(SolrInputDocument) reverses docs in a block quite
unreasonably.
So, there might be two vision on it:
* we can allow users to be aware about physical layout of docs, and need to
remove useless reverse in AddUpdateCommand.flatten() - not a big deal;
* we don't want users to rely, and oblige them to nest grand children into
children as well as children are nested into parents. (in this case, how to
prevent them from relying on reversing?)
Please raise a separate issue for testGrandChildren(). it can be temporarily
ignored for a while.
Thanks.
> BJQParserTest reproducible failures
> -----------------------------------
>
> Key: SOLR-5168
> URL: https://issues.apache.org/jira/browse/SOLR-5168
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Assignee: Yonik Seeley
> Attachments: BJQTest.patch
>
>
> two recent Jenkins builds have uncovered some test seeds that cause failures
> in multiple test methods in BJQParserTest. These seeds reproduce reliably
> (as of trunk r1514815) ...
> {noformat}
> ant test -Dtestcase=BJQParserTest -Dtests.seed=7A613F321CE87F5B
> -Dtests.multiplier=3 -Dtests.slow=true
> ant test -Dtestcase=BJQParserTest -Dtests.seed=1DC8055F837E437E
> -Dtests.multiplier=2 -Dtests.nightly=true -Dtests.slow=true
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
