[
https://issues.apache.org/jira/browse/SOLR-5168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744016#comment-13744016
]
Hoss Man commented on SOLR-5168:
--------------------------------
Mikhail: I don't fully understand what's going on here yet, but i know Yonik is
on vaca for a week or so -- so i'll go ahead and commit your patch along with
an {{@Ignore}} on testGrandChildren
bq. we can allow users to be aware about physical layout of docs
I don't think we should _expect_ users to be aware of the layout. if we wnat to
have low level "grey box" tests that know about those details then so be it --
but the non-test code shouldn't assume end users know anything about the
implementation details unless we have no other choice.
bq. we don't want users to rely, and oblige them to nest grand children into
children as well as children are nested into parents.
This sounds like the right course of action: if you have child docs, use
addChildDocument on your parent doc; if you have grandchildren, use
addChildDocument on the appropriate existing child that is the parent of the
grand-child you want to add.
Based on the current API of SolrInputDocument, I can't imagine it working any
other way.
bq. Please raise a separate issue for testGrandChildren(). it can be
temporarily ignored for a while.
I'd prefer to leave this issue (SOLR-5168) open for now to track the test
failures until they are resolved (that's the point of it's existence).
It's not clear to me if you are saying that fixing the "grandchildren" issue
requires fixing AddUpdateCommand.flatten() -- in which case please open a new
issue to specifically address that. (if the fix for the new issue
automatically fixes this issue then great). If however the remaining problem
is simply bad assumptions in this test, then we can continue to use this issue
to track it.
> BJQParserTest reproducible failures
> -----------------------------------
>
> Key: SOLR-5168
> URL: https://issues.apache.org/jira/browse/SOLR-5168
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Assignee: Yonik Seeley
> Attachments: BJQTest.patch
>
>
> two recent Jenkins builds have uncovered some test seeds that cause failures
> in multiple test methods in BJQParserTest. These seeds reproduce reliably
> (as of trunk r1514815) ...
> {noformat}
> ant test -Dtestcase=BJQParserTest -Dtests.seed=7A613F321CE87F5B
> -Dtests.multiplier=3 -Dtests.slow=true
> ant test -Dtestcase=BJQParserTest -Dtests.seed=1DC8055F837E437E
> -Dtests.multiplier=2 -Dtests.nightly=true -Dtests.slow=true
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
