[ 
https://issues.apache.org/jira/browse/SOLR-4817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erick Erickson updated SOLR-4817:
---------------------------------

    Attachment: SOLR-4817.patch

I think this is good-to-go for trunk. Since this really is changing behavior 
between trunk and 4x I'll put up a separate patch for 4x, I hope today.

One thing this patch does is completely get rid of the fallback solr.xml string 
in ConfigSolrXmlOld.xml, it's made available for tests by being put in a test 
file solr-old-default.xml. The non-test code doesn't have any references to it. 
This is a stopgap during this period between deprecating persistence and 
getting rid of it altogether. There's a couple of odd test cases that work if 
the core container uses this default file but don't work if you use the 
standard solr.xml file, I don't have the bandwidth to chase that down now, but 
it'll come out when we remove persistence.
                
> Solr should not fall back to the back compat built in solr.xml in SolrCloud 
> mode.
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-4817
>                 URL: https://issues.apache.org/jira/browse/SOLR-4817
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: Mark Miller
>            Assignee: Erick Erickson
>            Priority: Minor
>             Fix For: 4.5, 5.0
>
>         Attachments: SOLR-4817.patch, SOLR-4817.patch
>
>
> A hard error is much more useful, and this built in solr.xml is not very good 
> for solrcloud - with the old style solr.xml with cores in it, you won't have 
> persistence and with the new style, it's not really ideal either.
> I think it makes it easier to debug solr.home to fail on this instead - but 
> just in solrcloud mode for now due to back compat. We might want to pull the 
> whole internal solr.xml for 5.0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to