[ 
https://issues.apache.org/jira/browse/SOLR-4817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erick Erickson updated SOLR-4817:
---------------------------------

    Attachment: SOLR-4817.patch

Latest patch, all tests pass. That said, I still need to look all the changes 
over in the morning. I suspect there are some changes that need to be modified 
re: getting tests to pass But now that all tests pass, perhaps I can be a bit 
more discriminating in terms of what changes are really necessary.

In particular, SolrTestCaseJ4.copyTestSolrHome is a nocommit at this point. 
It's used once, but I'm thinking of leaving it in for the future as a handy 
method of copying all of a conf directory to a temp dir. It might replace a 
number of custom copy methods in various tests going forward.
                
> Solr should not fall back to the back compat built in solr.xml in SolrCloud 
> mode.
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-4817
>                 URL: https://issues.apache.org/jira/browse/SOLR-4817
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: Mark Miller
>            Assignee: Erick Erickson
>            Priority: Minor
>             Fix For: 4.5, 5.0
>
>         Attachments: SOLR-4817.patch, SOLR-4817.patch, SOLR-4817.patch
>
>
> A hard error is much more useful, and this built in solr.xml is not very good 
> for solrcloud - with the old style solr.xml with cores in it, you won't have 
> persistence and with the new style, it's not really ideal either.
> I think it makes it easier to debug solr.home to fail on this instead - but 
> just in solrcloud mode for now due to back compat. We might want to pull the 
> whole internal solr.xml for 5.0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to