[ 
https://issues.apache.org/jira/browse/SOLR-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757681#comment-13757681
 ] 

Erick Erickson commented on SOLR-2548:
--------------------------------------

[~hossman_luc...@fucit.org] Thanks. Your comments made me look more carefully 
at directExecutor, it took me a bit to wrap my head around that one.

1> Still checking on the implications of stacking up a bunch of directExecutors 
all through the CompletionService, not something I've used recently and the 
details are hazy.

As far as tests are concerned, I haven't gotten there yet, the original patch 
didn't have any... It should be easy to create tests with multiple field.facet 
clauses, TestFaceting does this so there are templates. Is there a decent way 
to check whether more than one thread was actually spawned? If so, can you 
point me at some code that actually does that? Otherwise I'll create tests that 
just get the right response for single and multiple facet.field specifications 
and a bit of walk-through with the debugger to insure we actually go through 
that code path.

2> done.

Thanks again.
                
> Multithreaded faceting
> ----------------------
>
>                 Key: SOLR-2548
>                 URL: https://issues.apache.org/jira/browse/SOLR-2548
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 3.1
>            Reporter: Janne Majaranta
>            Assignee: Erick Erickson
>            Priority: Minor
>              Labels: facet
>         Attachments: SOLR-2548_4.2.1.patch, SOLR-2548_for_31x.patch, 
> SOLR-2548.patch, SOLR-2548.patch
>
>
> Add multithreading support for faceting.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to