[ 
https://issues.apache.org/jira/browse/SOLR-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758261#comment-13758261
 ] 

Erick Erickson commented on SOLR-2548:
--------------------------------------

bq: Was there a bug that these changes fixed?

Nope, I thought it was a refactoring and didn't look closely. It appears to be 
useless complexity, perhaps a remnant from the original patch against 3.1. I 
took them out.

bq: please let's not do that for multi-threaded code.

I can always count on you to call me on sleeping, don't know why I even try to 
put a sleep in any more :). OK, took it out and substituted a notifyAll. And 
added a test that gets into this code while actually doing the inverting rather 
than just pulls stuff from the cache.

I'll attach a new patch in a few.
                
> Multithreaded faceting
> ----------------------
>
>                 Key: SOLR-2548
>                 URL: https://issues.apache.org/jira/browse/SOLR-2548
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 3.1
>            Reporter: Janne Majaranta
>            Assignee: Erick Erickson
>            Priority: Minor
>              Labels: facet
>         Attachments: SOLR-2548_4.2.1.patch, SOLR-2548_for_31x.patch, 
> SOLR-2548.patch, SOLR-2548.patch, SOLR-2548.patch
>
>
> Add multithreading support for faceting.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to