[
https://issues.apache.org/jira/browse/SOLR-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13791252#comment-13791252
]
ASF subversion and git services commented on SOLR-5255:
-------------------------------------------------------
Commit 1530861 from [email protected] in branch 'dev/branches/lucene_solr_4_5'
[ https://svn.apache.org/r1530861 ]
SOLR-4590, SOLR-5295, SOLR-5296, SOLR-5263, SOLR-5297, SOLR-5301, SOLR-5255,
SOLR-5305, SOLR-5314: Merging r1526616, r1528433, r1528441, r1528461, r1528488,
r1529341, r1529434, r1529503, r1530268 from branch_4x
> Extraneous zookeeper call in ZkStateReader cluster state watcher and setting
> wrong watcher
> ------------------------------------------------------------------------------------------
>
> Key: SOLR-5255
> URL: https://issues.apache.org/jira/browse/SOLR-5255
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Affects Versions: 4.4, 4.5, 5.0
> Reporter: Jessica Cheng
> Assignee: Shalin Shekhar Mangar
> Labels: cloud, zookeeper
> Fix For: 4.6, 5.0
>
>
> In ZkStateReader.createClusterStateWatchersAndUpdate, in the watcher for the
> call to watch CLUSTER_STATE:
> List<String> liveNodes = zkClient.getChildren(
> LIVE_NODES_ZKNODE, this, true);
>
> Set<String> liveNodesSet = new HashSet<String>();
> liveNodesSet.addAll(liveNodes);
> The liveNodesSet set is never used in subsequent code, since the new cluster
> state is made from the live node set from the existing cluster state:
> Set<String> ln = ZkStateReader.this.clusterState.getLiveNodes();
> ClusterState clusterState = ClusterState.load(stat.getVersion(), data,
> ln);
> ...which is as it should since this is a watcher for cluster state (if live
> nodes changes, the watcher for live nodes will be invoked).
> Due to the above extraneous call, however, now the cluster state watcher
> (this) is also set on the LIVE_NODES_ZKNODE path, which is unnecessary to
> fire when live nodes changed.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
