[
https://issues.apache.org/jira/browse/LUCENE-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807060#comment-13807060
]
Adrien Grand commented on LUCENE-5157:
--------------------------------------
This issue has been stalled for a few months now. Looking back at it, I think
that the changes that Boaz proposes make the API easier to understand. It might
be less general but this class is experimental so it will be possible to change
the API again in the future is we want.
I propose to commit the patch. If there are objections, I'll just close this
issue as "Won't fix" and commit the suggested assertion in
MultiOrdinals.getSegmentOrd.
> Refactoring MultiDocValues.OrdinalMap to clarify API and internal structure.
> ----------------------------------------------------------------------------
>
> Key: LUCENE-5157
> URL: https://issues.apache.org/jira/browse/LUCENE-5157
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Boaz Leskes
> Assignee: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-5157.patch
>
>
> I refactored MultiDocValues.OrdinalMap, removing one unused parameter and
> renaming some methods to more clearly communicate what they do. Also I
> renamed subIndex references to segmentIndex.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
