[ 
https://issues.apache.org/jira/browse/LUCENE-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807127#comment-13807127
 ] 

Robert Muir commented on LUCENE-5157:
-------------------------------------

I thought i gave a +1 above :)

Not an objection just reiterating my previous hesitation: for example if I had 
that the time I would patch query-time join to use this class to support global 
ordinals across even different readers instead of huge hashmaps of terms, I 
think this would be much faster as its just an int<->int join.

Then the segment number stuff might look wierd and the old API more intuitive, 
but this patch is fine for now!

> Refactoring MultiDocValues.OrdinalMap to clarify API and internal structure.
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-5157
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5157
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Boaz Leskes
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-5157.patch
>
>
> I refactored MultiDocValues.OrdinalMap, removing one unused parameter and 
> renaming some methods to more clearly communicate what they do. Also I 
> renamed subIndex references to segmentIndex.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to