[
https://issues.apache.org/jira/browse/LUCENE-5329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828053#comment-13828053
]
Michael McCandless commented on LUCENE-5329:
--------------------------------------------
Patch looks good!
When you say:
{code}
* if any of the term or (optionally) payload fields supplied
* do not have a value for a document, then the document is
* rejected by the dictionary
{code}
Does that mean the document is silently skipped? (rejected sounds like it may
throw an exception).
Why did liveDocs need to become non-final?
Instead of trying to pull the NumericDocValues for weight on every getWeight
call, could we do it up front in the ctor? And, just use MultiDocValues
(instead of holding leaves, starts and doing the bin search ourselves).
> Make DocumentDictionary and co more lenient to dirty documents
> --------------------------------------------------------------
>
> Key: LUCENE-5329
> URL: https://issues.apache.org/jira/browse/LUCENE-5329
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Reporter: Areek Zillur
> Attachments: LUCENE-5329.patch, LUCENE-5329.patch, LUCENE-5329.patch,
> LUCENE-5329.patch
>
>
> Currently DocumentDictionary errors out whenever any document does not have
> value for any relevant stored fields. It would be nice to make it lenient and
> instead ignore the invalid documents.
> Another "issue" with the DocumentDictionary is that it only allows string
> fields as suggestions and binary fields as payloads. When exposing these
> dictionaries to solr (via https://issues.apache.org/jira/browse/SOLR-5378),
> it is inconvenient for the user to ensure that a suggestion field is a string
> field and a payload field is a binary field. It would be nice to have the
> dictionary "just work" whenever a string/binary field is passed to
> suggestion/payload field. The patch provides one solution to this problem (by
> accepting string or binary values), though it would be great if there are any
> other solution to this, without making the DocumentDictionary "too flexible"
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
