[
https://issues.apache.org/jira/browse/LUCENE-5356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852779#comment-13852779
]
Dawid Weiss commented on LUCENE-5356:
-------------------------------------
I looked at the patch and wanted to apply it but there are still some
showstoppers to me.
- property deprecation was not handled the way I mentioned in my previous
comment
- the default mode should be backwards compatible (no custom dictionary =>
Polish dictionary), so the test should pass without passing 'pl' as the
dictionary too. a custom-dictionary test should be added.
- javadocs and comments need to be updated to reflect this change
- MorfologikLemmatizer is not needed at all, an IStemmer is enough (this class
is a dummy delegate now)
- this is not the same:
{code}
- me.setContextClassLoader(PolishStemmer.class.getClassLoader());
- this.stemmer = new PolishStemmer();
+ me.setContextClassLoader(MorfologikLemmatizer.class.getClassLoader());
+ this.stemmer = new MorfologikLemmatizer(dict);
{code}
the context class loader should be left as it was (pointing to PolishStemmer);
if the custom dictionary is within that classloader's scope (it should be)
it'll be loaded.
> more generic lucene-morfologik integration
> ------------------------------------------
>
> Key: LUCENE-5356
> URL: https://issues.apache.org/jira/browse/LUCENE-5356
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Affects Versions: 4.6
> Reporter: Michal Hlavac
> Assignee: Dawid Weiss
> Priority: Minor
> Labels: newbie, patch
> Fix For: 5.0, 4.7
>
> Attachments: LUCENE-5356.patch, LUCENE-5356.patch
>
>
> I have little proposal for morfologik lucene module. Current module is
> tightly coupled with polish DICTIONARY enumeration.
> But other people (like me) can build own dictionaries to FSA and use it with
> lucene.
> You can find proposal in attachment and also example usage in analyzer
> (SlovakLemmaAnalyzer).
> It uses dictionary property as String resource from classpath, not
> enumeration.
> One change is, that dictionary variable must be set in MofologikFilterFactory
> (no default value).
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
