[
https://issues.apache.org/jira/browse/LUCENE-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13862352#comment-13862352
]
Hoss Man commented on LUCENE-5383:
----------------------------------
"pull request" is vague - github is the flavor of the year, but that doesn't
mean it will be obvious what system "pull request #xxx" refers to a year from
now. I would suggest a convention of "github pull req #xxx" may help clarify
longer term.
bq. I don't trust GITHUB and the persistence of links to their system.
+1
bq. So we have to make sure the links to non-apache resources from our
changes.txt are persistent!
-0
We've never, to my knowledge, had a hard and fast rule that every entry in
CHANGES.txt needed to have an issue# (Jira now, bugzilla once upon a time)
associated with it - but we've built up our tools such that *if* they have an
issue number we link to it if we can.
I don't see how referring to github pull requests (or github issue# if people
start filing those, or CVE numbers, or hyperlinking raw URLs people type in) is
really any different.
If we start getting more patches from github pull requests, and more people
start committing those patches directly w/o opening jira issues, then having
_some_ ref id in CHANGES.txt to refer to those contributions is better then
nothing. And if we can _also_ make a best effort to link those ref ids to
more context on a third party system, we should attempt to do so -- even if we
can't guarantee those links are persistent.
As long as the build doesn't fail if the third party server is down when we're
trying to generate the changes.html, I don't see a problem with it. (it's no
different then the way we generate javadocs that link to Oracle -- we don't
trust that Oracle's servers will be up when we generate the links, but we do
assume the links won't change, and if they do - oh well.)
> fix changes2html to link pull requests
> --------------------------------------
>
> Key: LUCENE-5383
> URL: https://issues.apache.org/jira/browse/LUCENE-5383
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Robert Muir
>
> If someone submits a pull request, i think we should put it in changes.txt in
> some way similar to the jira issues:
> e.g. for a JIRA issue we do:
> {noformat}
> * LUCENE-XXXX: Add FooBar. (Joe Contributor via John Committer)
> {noformat}
> changes2html recognizes and expands these to jira issue links.
> so I think we should be able to do something like:
> {noformat}
> * pull request #xxx: Add FooBar. (Joe Contributor via John Committer)
> {noformat}
> and have it link to the request, too.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
