[
https://issues.apache.org/jira/browse/LUCENE-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13862363#comment-13862363
]
Hoss Man commented on LUCENE-5383:
----------------------------------
bq. it should also be recognized by github so the contributor knows we actually
committed the thing.
isn't that more a question of the commit message then what appears in
CHANGES.txt?
I believe all github cares about (for updating the pull request metdata on
their end) is the commit message -- so as long as that says "pull request #xxx"
they'll do there thing -- we should put whatever we think is best in
CHANGES.txt to help us understand the providence of the code. I think adding
the word "github" somewhere near "#xxx" would be helpful for us to keep things
straight in the long term,
> fix changes2html to link pull requests
> --------------------------------------
>
> Key: LUCENE-5383
> URL: https://issues.apache.org/jira/browse/LUCENE-5383
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Robert Muir
>
> If someone submits a pull request, i think we should put it in changes.txt in
> some way similar to the jira issues:
> e.g. for a JIRA issue we do:
> {noformat}
> * LUCENE-XXXX: Add FooBar. (Joe Contributor via John Committer)
> {noformat}
> changes2html recognizes and expands these to jira issue links.
> so I think we should be able to do something like:
> {noformat}
> * pull request #xxx: Add FooBar. (Joe Contributor via John Committer)
> {noformat}
> and have it link to the request, too.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
