GitHub user NightOwl888 opened a pull request:
https://github.com/apache/lucenenet/pull/185
Ported Core.Util.Fst tests + Core.Util.Packed.TestPackedInts test
This includes 3 missing test files from Core.Util, several bug fixes to
make the Core.Util.Fst tests pass (all green), and API refactoring to .NETify
the API and make the FST generics act more like they do in Java Lucene.
6 of the Core.Util.Packed.TestPackedInts tests are failing, and 1
additional test needs some additional work to make complete (which I have
marked with an Ignore attribute). I looked into the failing tests briefly -
they are all failing due to incorrect results from the RAMUsageEstimator, not
due to problems with the PackedInts class.
There is [1 FST
test](https://github.com/NightOwl888/lucenenet/blob/ef889cebdeaa180d0bb232afd8e5ab3865cd41bc/src/Lucene.Net.Tests/core/Util/Fst/TestFSTs.cs#L312)
that I estimate will take around 10-14 hours to complete. It was marked with a
"Nightly" attribute in Lucene. Perhaps there should be such an attribute in
Lucene.Net?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NightOwl888/lucenenet core-fst
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucenenet/pull/185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #185
----
commit c67366fd4b383c31971a8ae68b458dec7aee2d7f
Author: Shad Storhaug <[email protected]>
Date: 2016-09-05T14:25:35Z
Setup InternalsVisibleTo Lucene.Net.Core <- Lucene.Net.Tests for testing.
commit b56ebc22bb06fddc941b467d8310cfd735e5f9e9
Author: Shad Storhaug <[email protected]>
Date: 2016-09-06T06:17:13Z
Setup InternalsVisibleTo Lucene.Net.TestFramework <- Lucene.Net.Tests for
testing.
commit 243ada716c47dafeaf8d2aa39c9ebd8f4c0e8bd7
Author: Shad Storhaug <[email protected]>
Date: 2016-09-05T11:21:23Z
Fixed bugs in FST that were causing test failures and Debug.Assert failures
in Misc.Util.Fst.
commit 9a562204f973b8380ead3ed89fc3ee527fa904a9
Author: Shad Storhaug <[email protected]>
Date: 2016-09-05T12:21:45Z
Ported Core.Util.Fst.TestBytesStore
commit 297f92653a0e8e64c25b171444ca18f0387f190a
Author: Shad Storhaug <[email protected]>
Date: 2016-09-06T07:18:19Z
.NETify FST: Public member names should be PascalCase.
commit 3da18fb7d9101d42fedc5932fb22afc7254c52a4
Author: Shad Storhaug <[email protected]>
Date: 2016-09-06T11:55:43Z
Ported Core.Util.Fst.TestFSTs
commit 5effb005955f357825cb9447f186b221a8d63cb7
Author: Shad Storhaug <[email protected]>
Date: 2016-09-06T19:01:26Z
Ported Core.Util.Packed.TestPackedInts
commit 510413ce4b99d15a79a70d876e5f89ca657dc193
Author: Shad Storhaug <[email protected]>
Date: 2016-09-07T09:18:17Z
.NETify FST: Changed Final, Last, Compiled, and Reversed() to IsFinal,
IsLast, IsCompiled, and IsReversed to make it clear that they are boolean
states.
commit dfa23109cbe204fa9339e7d4ab23f854c18b46c9
Author: Shad Storhaug <[email protected]>
Date: 2016-09-07T09:49:13Z
Removed duplicate (hidden) class definitions in FST.
commit b8db797ba917041dabe034e3ddf5960dd14fc04a
Author: Shad Storhaug <[email protected]>
Date: 2016-09-07T10:28:33Z
.NETify FST: Private/protected fields should be camelCase.
commit 18f84437970c1cc0d16312952a4e6726d35f97df
Author: Shad Storhaug <[email protected]>
Date: 2016-09-07T10:30:10Z
.NETify FST: Interfaces should start with "I"
commit 3994051b243f9e4a39cdda107ac8c6d1d68a78e2
Author: Shad Storhaug <[email protected]>
Date: 2016-09-07T11:07:43Z
Moved BytesRefFSTEnum<T>.InputOutput<T> and
IntsRefFSTEnum<T>.InputOutput<T> classes into non-generic classes with the same
name so we don't need to specify the generic type twice.
commit 0ccb5b65809ad6b341b3b04fcdfb43c58e53aff5
Author: Shad Storhaug <[email protected]>
Date: 2016-09-07T11:17:58Z
Normalized FST license headers
commit 01e903b1022cf13d708d8c1b5502047ebf704459
Author: Shad Storhaug <[email protected]>
Date: 2016-09-07T20:11:08Z
Refactored FST class to disallow the verbose and confusing FST<T>.Arc<T>
syntax, favoring FST.Arc<T>.
commit 8617aa9997568d9fc72743f68784b60f9d2ddbd2
Author: Shad Storhaug <[email protected]>
Date: 2016-09-07T17:06:47Z
Fixed infinite recursion issue and key not found bugs in the FSTTester
commit d807eeba7a8cdbb3efc54a00e12312ea0f11b308
Author: Shad Storhaug <[email protected]>
Date: 2016-09-07T17:46:08Z
Core.Util.Fst.TestFSTs: Fixed infinite recursion bug in TestRealTerms().
Use Environment.TickCount rather than DateTime.Now.Millisecond when doing time
sensitive testing.
commit 32e2105bba349544c3166d30f664ef7edd219a3a
Author: Shad Storhaug <[email protected]>
Date: 2016-09-07T19:19:29Z
TestFSTs: Added LongRunningTest and Ignore attributes for applicable tests.
commit ef889cebdeaa180d0bb232afd8e5ab3865cd41bc
Author: Shad Storhaug <[email protected]>
Date: 2016-09-07T22:23:58Z
Fixed issue with SortedSet not being emptied in Core.Util.Fst.Util, and
added thread safety, since SortedSet doesn't have the necessary atomic
operations.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
