Github user NightOwl888 commented on a diff in the pull request:

    https://github.com/apache/lucenenet/pull/185#discussion_r78303088
  
    --- Diff: src/Lucene.Net.Tests/core/Util/TestWeakIdentityMap.cs ---
    @@ -174,12 +188,15 @@ public virtual void TestSimpleHashMap()
                 Assert.IsTrue(map.Empty);
             }
     
    +        /* LUCENENET TODO: Compile issues
    --- End diff --
    
    I realize that. I noticed a few other test files that have comments such as 
these - most of them seem to be around using threading and thread pools, which 
are somewhat difficult to port.
    
    This wasn't intended to be a thorough completion of the tests, but it will 
reduce the amount of effort to be thorough in another pass. Frankly, I was 
trying to see if there were any unfinished tests that could help me locate a 
Lucene.Net.Misc test failure due to a bug that is somewhere in the core. I 
chased after it for a couple of days before trying the shotgun approach - which 
seemed more productive since these tests need to be completed anyway. 
Unfortunately, it didn't help me locate the bug. I will point it out and go 
into details about it when I make the pull request for Suggest/Misc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to