laimis commented on code in PR #801:
URL: https://github.com/apache/lucenenet/pull/801#discussion_r1160912632


##########
src/Lucene.Net.Analysis.Common/Analysis/Util/OpenStringBuilder.cs:
##########
@@ -56,7 +56,9 @@ public virtual int Length
             set => m_len = value;
         }
 
-        public virtual void Set(char[] arr, int end)
+        // LUCENENET specific - S1699 - marked non-virtual because calling
+        // virtual members from the constructor is not a safe operation in .NET
+        public void Set(char[] arr, int end)

Review Comment:
   Fixed here https://github.com/apache/lucenenet/pull/803



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to