laimis commented on code in PR #801:
URL: https://github.com/apache/lucenenet/pull/801#discussion_r1161059837
##########
src/Lucene.Net/Search/DisjunctionMaxQuery.cs:
##########
@@ -92,7 +92,9 @@ public DisjunctionMaxQuery(ICollection<Query> disjuncts,
float tieBreakerMultipl
/// <summary>
/// Add a subquery to this disjunction </summary>
/// <param name="query"> The disjunct added </param>
- public virtual void Add(Query query)
+ // LUCENENET specific - S1699 - marked non-virtual because calling
+ // virtual members from the constructor is not a safe operation in .NET
+ public void Add(Query query)
Review Comment:
Fixed with https://github.com/apache/lucenenet/pull/807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
