laimis opened a new pull request, #804: URL: https://github.com/apache/lucenenet/pull/804
Continuation of fixes with virtual calls being made from constructors. The issue originally reported by SonarCloud scans: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS1699&id=apache_lucenenet and referenced in this issue: https://github.com/apache/lucenenet/issues/670 This one focuses on SpellChecker. We are simply removing the virtual designation. It seems like Lucene team has been planning this as well based on TODO: comment above the method but has not pulled the trigger. We are going to go ahead and do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
