NightOwl888 commented on code in PR #804: URL: https://github.com/apache/lucenenet/pull/804#discussion_r1160917415
########## src/Lucene.Net.Suggest/Spell/SpellChecker.cs: ########## @@ -142,8 +142,9 @@ public SpellChecker(Directory spellIndex, IStringDistance sd, IComparer<SuggestW /// <param name="spellIndexDir"> the spell directory to use </param> /// <exception cref="ObjectDisposedException"> if the Spellchecker is already closed </exception> /// <exception cref="IOException"> if spellchecker can not open the directory </exception> - // TODO: we should make this final as it is called in the constructor Review Comment: We should probably keep this Lucene comment here. Or at least explain that we made this decision because it was intended this way by the Lucene team. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org