laimis commented on code in PR #801:
URL: https://github.com/apache/lucenenet/pull/801#discussion_r1161276832
##########
src/Lucene.Net/Store/ByteArrayDataOutput.cs:
##########
@@ -51,12 +51,16 @@ public ByteArrayDataOutput()
Reset(BytesRef.EMPTY_BYTES);
}
- public virtual void Reset(byte[] bytes)
+ // LUCENENET specific - S1699 - marked non-virtual because calling
+ // virtual members from the constructor is not a safe operation in .NET
+ public void Reset(byte[] bytes)
Review Comment:
Fixed in https://github.com/apache/lucenenet/pull/814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
