paulirwin opened a new pull request, #914: URL: https://github.com/apache/lucenenet/pull/914
<!-- Thank you for submitting a pull request to our repo. --> <!-- Please do NOT submit PRs for features in newer versions of Lucene. We should keep the target version consistent across our repository to make the upgrade process to newer versions of Lucene go smoothly. --> <!-- If this is your first PR in the Lucene.NET repo, please run through the checklist below to ensure a smooth review and merge process for your PR. --> - [X] You've read the [Contributor Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html). - [X] You've included unit or integration tests for your change, where applicable. - [X] You've included inline docs for your change, where applicable. - [X] There's an open issue for the PR that you are making. If you'd like to propose a change, please [open an issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the change or find an existing issue. <!-- Once all that is done, you're ready to go. Open the PR with the content below. --> Test review for core namespaces J-S Partial work for #259 ## Description - Test review and code cleanup for J-S tests - Formatting updated to match upstream Java code for easier line-by-line comparison - Miscellaneous test performance improvements (variables -> consts, some singleton instances added) - Note: some removals of unused `outerInstance` for inner/anonymous classes that did not use it. Reviewed latest Lucene Java code to ensure this capturing isn't use so that it won't be burdensome work to re-add later. Many cases were actually `static` inner classes in Java so this was incorrect anyways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
