paulirwin commented on code in PR #914:
URL: https://github.com/apache/lucenenet/pull/914#discussion_r1501710026


##########
src/Lucene.Net.Tests/Search/Spans/TestSpans.cs:
##########
@@ -556,6 +609,7 @@ public virtual void TestSpanNots()
 
         [Test]
         [Description("LUCENENET-597")]
+        [LuceneNetSpecific]

Review Comment:
   It looks to me to only be used for debugging purposes. Here is the original 
JIRA ticket: https://issues.apache.org/jira/browse/LUCENENET-597
   
   And here is the commit: 
https://github.com/apache/lucenenet/commit/de4032a7da9887d9830c5b2fc680c0d1e8654bce
   
   Any change to this is I think outside the scope of this PR; this was 
deliberately changed in that commit to fix that issue. I am just marking it as 
LuceneNetSpecific here since the test does not exist in the Java code. My guess 
is that the current behavior is fine as it just matches the .NET type name and 
Boolean string formatting style in .NET.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to