NightOwl888 commented on issue #268: URL: https://github.com/apache/lucenenet/issues/268#issuecomment-2444499422
>At this point, I don't know if it makes sense to try to attempt this for 4.8, and that porting work is already done. I think we can revisit this for the next post-4.8 release, so I'm moving this back to the Future milestone for now. @paulirwin - Actually, out of all of the packages, this one is the least "done". 1. There are still many culture aware APIs that we are calling that we probably shouldn't be. 2. There is no way to localize the error messages like there was in Lucene. We had that, but I ripped out the NLS error message resources long time ago. Maybe it is time to have a look at using localized satellite assemblies, which might be a better option in .NET. While having no TryParse and having it throw exceptions to loop back to the prior position in a string are also pretty bad, query strings don't tend to be too long, so it is probably okay for this use case. But fixing it so it doesn't throw exceptions just to loop back would be much easier if we generated the code for the query string grammar rather than hand porting it like this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
