paulirwin commented on issue #268: URL: https://github.com/apache/lucenenet/issues/268#issuecomment-2444578730
> But fixing it ... would be much easier if we generated the code for the query string grammar rather than hand porting it like this. I wanted this to be feasible, as I think it's a good goal. And I wish that were "easier," but see my comment above. None of these automated approaches are particularly easy. The generated files are only ~750 lines of Java each, compared to how many thousands of lines and hours of porting javacc, or having ANTLR syntax that does not match upstream, or having to add rewriting and build task support to JavaToCSharp. javacc is not a trivial syntax to implement a generator for, unfortunately. I could envision easily spending hundreds of hours on this problem, just to save myself one or two fewer orders of magnitude by just updating the generated code by hand (including even getting it up to date as of 10.0 for the next release). This is compounded by the chicken-and-egg problem of needing to know what our desired generated code would look like with those exception and i18n changes you mention above, before we know how to write a generator for it, at which point we might as well hand-po rt the first version of that anyways, regardless of if we automate it or not. Of note, the Lucene team commits their generated Java code to the repo, so it will be easy to do diffs to see what changed, if we want to continue to hand-port it in the future. If we decide to update the generated code manually to factor in the requested changes above, I think we can split that off as its own issue, since that would be separate from "Automate Generation of QueryParser to C#." And that seems like a reasonable thing to include in 4.8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
