paulirwin commented on code in PR #1014:
URL: https://github.com/apache/lucenenet/pull/1014#discussion_r1836900784
##########
src/Lucene.Net.Tests/Index/TestDirectoryReaderReopen.cs:
##########
@@ -393,7 +386,7 @@ public override void Run()
if (index % 2 == 0)
{
// refresh reader synchronized
- ReaderCouple c = (outerInstance.RefreshReader(r, test,
index, true));
+ ReaderCouple c = outerInstance.RefreshReader(r, test,
index, true);
Review Comment:
Agreed, I'm all in favor of making methods static where possible. Slightly
better performance of not having to load the `this` argument (as well as all
the other `outerInstance` use). I went ahead and did that for two other methods
in this class as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
