paulirwin commented on code in PR #1049: URL: https://github.com/apache/lucenenet/pull/1049#discussion_r1859033674
########## src/Lucene.Net.TestFramework/Index/BaseTermVectorsFormatTestCase.cs: ########## @@ -360,7 +360,8 @@ public sealed override bool IncrementToken() { if (i < terms.Length) { - termAtt.SetLength(0).Append(terms[i]); + termAtt.Length = 0; Review Comment: Done; added the extension method for SetLength, added Clear() to the interface (it was already on the concrete type via implementing Attribute's abstract method), moved SetEmpty to the extensions, and updated doc references. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org