paulirwin commented on code in PR #1049:
URL: https://github.com/apache/lucenenet/pull/1049#discussion_r1866097331
##########
src/Lucene.Net/Analysis/TokenAttributes/CharTermAttributeImpl.cs:
##########
@@ -107,32 +107,27 @@ private void GrowTermBuffer(int newSize)
}
}
- int ICharTermAttribute.Length { get => Length; set =>
SetLength(value); }
+ int ICharTermAttribute.Length
Review Comment:
It appears that also the explicit implementations for
`ICharTermAttribute.Buffer`, `ICharSequence.this[int index]`,
`ICharTermAttribute.this[int index]`, `ICharTermAttribute.CopyBuffer`, and
`ICharTermAttribute.ResizeBuffer` are not needed either (i.e. for covariant
return types). I'll go ahead and remove those as well since they just delegate
to the same methods/properties/indexer that would be called if implemented
implicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
