paulirwin opened a new pull request, #1052: URL: https://github.com/apache/lucenenet/pull/1052
- [X] You've read the [Contributor Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html). - [X] You've included unit or integration tests for your change, where applicable. - [X] You've included inline docs for your change, where applicable. - [X] There's an open issue for the PR that you are making. If you'd like to propose a change, please [open an issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the change or find an existing issue. Run tests on .NET 9 and add Stream.ReadExactly polyfill Fixes #1019 Fixes #1037 ## Description Adds .NET 9 to the test suite and sets necessary feature definitions. This also adds a polyfill extension method on Stream for the [ReadExactly](https://learn.microsoft.com/en-us/dotnet/api/system.io.stream.readexactly?view=net-9.0) method, which causes a [build warning](https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2022) on .NET 9 if you read from a stream without checking the result. Since this method neatly encapsulates this best practice, it seemed prudent to add this extension method for older targets and use the method directly on .NET 9. This de facto adds additional assertions to the tests as well, improving reliability. Due to the netstandard1.x warning, this PR also fixes #1037 and suppresses the warning for the code analysis projects on netstandard1.3 that must support Visual Studio 2017. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
