paulirwin commented on issue #1059: URL: https://github.com/apache/lucenenet/issues/1059#issuecomment-2543388273
An update: I have the GroupingSearch class split out, and many of the interfaces and covariance removed, I just have one failing unit test that I am having difficulty tracking down. You can track my progress at my branch: https://github.com/paulirwin/lucene.net/tree/issue/1059 - or I welcome if anyone can pull that down and see what the problem is. The tests are a bit wonky as I have to create types that use `object` as the generic type parameter to mimic the previous covariance, since the tests randomly create either Term or Function versions based on a random boolean. Having an object-based wrapper class helps me get around needing covariance. The types BytesRef and MutableValue are already reference types, so converting them to object just for the tests is not a problem, it's just mildly annoying to have to cast them back out when needed. The GroupingSearch class now has three helper factory methods, but you also could use the split-out classes directly if you wanted to. I'll add XML doc comments before I publish the PR, for now I'm focused on getting it working. Once I get the failing test working, I'll finish removing the interfaces, then focus on converting IEnumerable back to ICollection and the other items on the list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
