NightOwl888 commented on issue #1059: URL: https://github.com/apache/lucenenet/issues/1059#issuecomment-2543446056
> Re: "Restore generic collections where we are currently using ICollection and IDictionary", ICollection is no longer there, but IDictionary still is, because that requires Lucene.Net.Queries.Function.ValueSource to have a generic dictionary context argument to GetValues, and that would be a much larger change. I think that can be broken out as its own issue/PR as this is big enough as it is, and this being non-generic only affects the Function types, so the scope is pretty limited. > > I think we can safely replace IDictionary with `IDictionary<object, object>` in that case. Still loosely typed to object, but we kinda have to because it's designed to just be a form of a cache that is passed around. Some implementations (like ScaleFloatFunction) use non-string keys as well, so it's not safe to make it `IDictionary<string, object>`. Would it make sense to add the closing types of `IDictionary<TKey, TValue>` to the classes that wrap them? It looks like we could cascade that down from `AbstractGroupingSearch<T, TKey, TValue>` down to the others like `AbstractFirstPassGroupingCollector<T, TKey, TValue>`, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
