paulirwin opened a new pull request, #1079:
URL: https://github.com/apache/lucenenet/pull/1079

   - [X] You've read the [Contributor 
Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code 
of Conduct](https://www.apache.org/foundation/policies/conduct.html).
   - [X] You've included unit or integration tests for your change, where 
applicable.
   - [X] You've included inline docs for your change, where applicable.
   - [X] There's an open issue for the PR that you are making. If you'd like to 
propose a change, please [open an 
issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the 
change or find an existing issue.
   
   Converts static readonly fields to const, where possible.
   
   Fixes #662
   
   ## Description
   
   This PR converts most static readonly fields to const where it is possible 
to do so. Some notable exceptions:
   
   1. The analysis was not focused on any fields in unit test projects.
   2. Any fields whose values changed in the latest Lucene were kept as static 
readonly, to be on the safe side.
   3. If there were other, similar fields that needed to be static readonly, 
the ones that were const-able were left as-is for consistency.
   4. Fields like VERSION_CURRENT were left as-is, since it might be expected 
to evaluate those.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to